Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Include SVG Illustrations in an external, cached file

Download Browse

Part of story #13640: See minimal card display All inline SVG in Vue components is replaced by <use> tags with [href]. All SVG illustrations are now stored in a "illustrations.svg" file. Its name is hashed, so it can be cached by browsers and no longer needs to be loaded in the Vue bundle. It uses CSS variables (Custom Properties) to style the individual SVG parts. This is not supported by IE11 [0] but Taskboard does not support IE11 anyway. [0]: https://caniuse.com/#feat=css-variables Change-Id: I2b93e65286c29a95e30631807759a6fcc5ac6eb4

+326 −317
Joris MASSON (jmasson) 2019-09-11 16:04
Joris MASSON (jmasson) 2019-09-12 08:56
d8b3f5d76906db5adfd02f72abc8afc90af2cab1
4253e49f67e28339dbdacf55bd974f64378750bd
git #tuleap/stable/d8b3f5d76906db5adfd02f72abc8afc90af2cab1

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/scripts/taskboard/src/components/EmptyState/NoContentEmptyState.vue +5 −6 Go to diff View file
D plugins/taskboard/scripts/taskboard/src/components/EmptyState/NoContentSvg.vue +0 −133 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/EmptyState/__snapshots__/NoContentEmptyState.test.ts.snap +13 −4 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/GlobalError/BoardWithoutAnyColumnsErrorForAdmin.vue +4 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/GlobalError/BoardWithoutAnyColumnsErrorForUsers.vue +5 −6 Go to diff View file
D plugins/taskboard/scripts/taskboard/src/components/GlobalError/BoardWithoutAnyColumnsForAdminSvg.vue +0 −86 Go to diff View file
D plugins/taskboard/scripts/taskboard/src/components/GlobalError/BoardWithoutAnyColumnsForUsersSvg.vue +0 −64 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/GlobalError/__snapshots__/BoardWithoutAnyColumnsErrorForAdmin.test.ts.snap +11 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/GlobalError/__snapshots__/BoardWithoutAnyColumnsErrorForUsers.test.ts.snap +15 −9 Go to diff View file
A plugins/taskboard/scripts/taskboard/src/images/illustrations.svg +255 −0 Go to diff View file
M plugins/taskboard/scripts/webpack.common.js +2 −1 Go to diff View file
M src/www/themes/common/tlp/src/scss/components/_illustration.scss +8 −1 Go to diff View file
M tools/utils/scripts/webpack-rule-configs.js +8 −1 Go to diff View file