stable
Clone or download
part of request #39022 Moving a card in Taskboard can have side effects No functional change. Unit and REST tests should pass. Why? This series of refactorings has the goal to make it easy to write a "domain" API to find the current column of a given card. This requires us to know which list bind values have been selected in the last changeset of a card's artifact. We continue by simplifying the retrieval of the bind values of a card. Also removed static build methods. The final, top-most endpoints should have the responsibility of instantiating everything, so that they can substitute interfaces with caches if needed. Instantiation should not be a responsibility of individual objects. Change-Id: Iafec03909f7d1023763d30d540b04ecfe6a44beb
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/taskboard/include/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetriever.php | +14 | −16 | Go to diff View file |
| M | plugins/taskboard/include/REST/v1/CardRepresentation.php | +7 | −4 | Go to diff View file |
| M | plugins/taskboard/include/REST/v1/CardRepresentationBuilder.php | +9 | −57 | Go to diff View file |
| M | plugins/taskboard/include/REST/v1/TaskboardCardResource.php | +44 | −2 | Go to diff View file |
| M | plugins/taskboard/include/REST/v1/TaskboardResource.php | +26 | −1 | Go to diff View file |
| M | plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetrieverTest.php | +16 | −14 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetValue_List.class.php | +3 | −5 | Go to diff View file |