stable

Clone or download

Read-only

request #21377: Optimize CompatPDODataAccess::escapeInt

When processing a large number of values this small change can save a non negligible amount of time. Ultimately this method should not be used at all and we should move everything to prepared statements. Until we can reach this point, saving a few CPU cycles on almost every requests is still nice to have 🌱. The signature of ::escapeInt() has been updated to have the true return value which has required a few fixes in the tracker and cardwall plugins. Change-Id: Ib472f58a3807a9ada4f542ba81699ee6bc1ee9fb

Modified Files

Name
M plugins/cardwall/include/Semantic/Dao/CardFieldsDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/dao/PriorityDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/dao/Tracker_ArtifactDao.class.php +2 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/dao/Tracker_Artifact_ChangesetDao.class.php +2 −3 Go to diff View file
M plugins/tracker/include/Tracker/DateReminder/dao/Tracker_DateReminderDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/Date/DateValueDao.php +2 −3 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/FieldDao.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ListFields/Bind/BindStaticValueDao.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/PermissionsOnArtifact/PermissionsOnArtifactFieldValueDao.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/dao/Tracker_Report_CriteriaDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/dao/Tracker_Report_RendererDao.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/dao/Tracker_Report_Renderer_Table_ColumnsDao.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/dao/Tracker_Report_Renderer_Table_SortDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Tooltip/dao/Tracker_TooltipDao.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/dao/TrackerDao.class.php +1 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/TrackerReportRendererTableTest.php +3 −3 Go to diff View file
M src/common/DB/Compat/Legacy2018/CompatPDODataAccess.php +2 −8 Go to diff View file
M src/common/DB/Compat/Legacy2018/LegacyDataAccessInterface.php +1 −3 Go to diff View file