Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Migrate codemirror-helper-service to TypeScript

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript This file has been renamed to code-mirror-common-sections-collapse since all it does now is collapse the sections of common lines in editors. Some unit tests have been written since there weren't any for this service. No functional change expected Change-Id: I18119bc2a77f7c35ecce777680819bbeb9848707

+266 −134
Thomas Gorka (tgorka) 2022-12-08 16:29
Thomas Gorka (tgorka) 2022-12-09 15:58
daebf3aab5a3a0d3a57e40d2a1aba9dfbd650116
bbf9046fcfe661e4faf6ce393e9f8d1f8ee18b8c
git #tuleap/stable/daebf3aab5a3a0d3a57e40d2a1aba9dfbd650116

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/app.js +0 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/code-collapse/collaspible-code-sections-builder.ts +2 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentBodyTemplate.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentFooterTemplate.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplyFormTemplate.test.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/new-comment-form/NewInlineCommentForm.test.ts +1 −1 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/code-mirror-common-sections-collapse.test.ts +142 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/code-mirror-common-sections-collapse.ts +91 −0 Go to diff View file
D plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js +0 −95 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +6 −9 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js +5 −19 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/gettext-catalog.ts +13 −0 Go to diff View file