stable

Clone or download

Read-only

Remove \get_server_url() function

The function is marked as deprecated since 2016. Since the upgrade to Psalm 3.4.5 it is also responsible for a non negligeable part of the issues found when a subpart of the codebase is analyzed (see the attached file in the request). The change affects some site-content files so a note in the deployment guide will need to be added. Part of request #13292: Integrate vimeo/psalm to the test pipeline Change-Id: I3006924885a9950c4952e2a10c3792bf05b8b4a0

Modified Files

Name
M plugins/docman/bin/DocmanExport/XMLExport.class.php +1 −1 Go to diff View file
M plugins/docman/include/ApprovalTable/NotificationCycle.class.php +3 −3 Go to diff View file
M plugins/docman/include/ApprovalTable/Reminder.class.php +2 −2 Go to diff View file
M plugins/docman/include/ApprovalTable/Reviewer/ReviewerFactory.class.php +2 −2 Go to diff View file
M plugins/docman/include/Docman_HTTPController.class.php +1 −1 Go to diff View file
M plugins/git/include/SystemEvents/SystemEvent_GIT_GERRIT_MIGRATION.class.php +2 −2 Go to diff View file
M plugins/graphontrackers/www/reportgraphic.php +2 −2 Go to diff View file
M plugins/mediawiki/www/images.php +2 −2 Go to diff View file
M plugins/proftpd/www/explorer.php +2 −2 Go to diff View file
M plugins/proftpd/www/index.php +2 −2 Go to diff View file
M plugins/projectlinks/www/projectlinks_admin.php +2 −2 Go to diff View file
M plugins/statistics/www/soap/index.php +2 −2 Go to diff View file
M plugins/statistics/www/soap/wsdl.php +1 −1 Go to diff View file
M plugins/svn/include/SVN/Repository/Repository.php +3 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/ArtifactChildPresenter.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/EmailNotificationTask.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/MailSender.php +8 −5 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactLinkInfo.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/DateReminder/Tracker_DateReminderManager.class.php +6 −4 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Burndown.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Migration/MailLogger.class.php +3 −3 Go to diff View file
M plugins/tracker/include/Tracker/TrackerManager.class.php +1 −1 Go to diff View file
M plugins/tracker_date_reminder/include/ArtifactDateReminderFactory.class.php +1 −1 Go to diff View file
M site-content/en_US/mail/html_template.php +2 −2 Go to diff View file
M site-content/en_US/project/tos.txt +1 −1 Go to diff View file
M site-content/en_US/tos/privacy.txt +2 −2 Go to diff View file
M site-content/fr_FR/project/tos.txt +1 −1 Go to diff View file
M site-content/fr_FR/tos/privacy.txt +2 −2 Go to diff View file
M src/common/Widget/Widget_MyProjects.class.php +7 −6 Go to diff View file
M src/common/docmanv1/XMLExport.class.php +2 −2 Go to diff View file
M src/common/frs/FRSReleaseFactory.class.php +7 −4 Go to diff View file
M src/common/frs/FileModuleMonitorFactory.class.php +8 −6 Go to diff View file
M src/common/mail/LogoRetriever.class.php +2 −2 Go to diff View file
M src/common/mail/MailPresenterFactory.class.php +2 −2 Go to diff View file
M src/common/mail/MailProjectNotificationMustBeApprovedPresenter.class.php +2 −2 Go to diff View file
M src/common/mail/MailProjectNotificationPresenter.class.php +2 −2 Go to diff View file
M src/common/mail/MailProjectOneStepRegisterPresenter.class.php +5 −5 Go to diff View file
M src/common/reference/CrossReference.class.php +4 −4 Go to diff View file
M src/common/reference/ReferenceInstance.class.php +5 −1 Go to diff View file
M src/common/system_event/SystemEvent.class.php +1 −1 Go to diff View file
M src/common/tracker/Artifact.class.php +9 −7 Go to diff View file
M src/common/tracker/ArtifactFile.class.php +2 −2 Go to diff View file
M src/common/tracker/HTML/ArtifactHtml.class.php +7 −6 Go to diff View file
M src/www/account/register.php +2 −2 Go to diff View file
M src/www/admin/approve_pending_users.php +1 −1 Go to diff View file
M src/www/cvs/commit_utils.php +1 −1 Go to diff View file
M src/www/include/account.php +0 −1 Go to diff View file
M src/www/include/proj_email.php +5 −5 Go to diff View file
M src/www/include/session.php +2 −2 Go to diff View file
M src/www/include/utils.php +0 −20 Go to diff View file
M src/www/my/rmproject.php +2 −2 Go to diff View file
M src/www/svn/svn_utils.php +2 −2 Go to diff View file
M src/www/tracker/gotoid.php +2 −1 Go to diff View file