Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Don't get submilestones if user cannot see parent

Download Browse

Part of story #35104 Milestones below Backlog If a user cannot see a parent artifact but can see its child, we should not get the childs. *Testing:* Set permissions of Releases to only submitters and permissions of Sprints to everyone. With a second user (not site-admin or project-admin) you should see only the releases you have created with their sprints. Change-Id: Iaa501afd447ebd433fa4a02724d82f564e9b065a

+1273 −554
Marie Ange Garnier (marieange) 2023-12-18 10:46
Kevin Traini (ktraini) 2023-12-19 10:10
dd98207a06253c5656506fe6e28c0ba03c622971
42b2f443f12d2715bdf8a4e08fbc7518cdb43fee
git #tuleap/stable/dd98207a06253c5656506fe6e28c0ba03c622971

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/AgileDashboardPromotedMilestonesRetriever.php +25 −148 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/BuildPromotedMilestone.php +36 −0 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/BuildPromotedMilestoneList.php +31 −0 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/PromotedMilestone.php +65 −0 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/PromotedMilestoneBuilder.php +86 −0 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/PromotedMilestoneList.php +95 −0 Go to diff View file
A plugins/agiledashboard/include/AgileDashboard/Milestone/Sidebar/PromotedMilestoneListBuilder.php +103 −0 Go to diff View file
M plugins/agiledashboard/include/AgileDashboardService.php +12 −6 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/AgileDashboardPromotedMilestonesRetrieverTest.php +42 −396 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/PromotedMilestoneBuilderTest.php +199 −0 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/PromotedMilestoneListBuilderTest.php +219 −0 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/PromotedMilestoneListTest.php +166 −0 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/PromotedMilestoneTest.php +56 −0 Go to diff View file
A plugins/agiledashboard/tests/unit/Stub/Milestone/Sidebar/BuildPromotedMilestoneListStub.php +59 −0 Go to diff View file
A plugins/agiledashboard/tests/unit/Stub/Milestone/Sidebar/PromotedMilestoneBuilderStub.php +60 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Artifact.php +9 −0 Go to diff View file
M plugins/tracker/tests/unit/Builders/ArtifactTestBuilder.php +10 −4 Go to diff View file