Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract FeatureRemovalProcessor

Download Browse

Part of story #20111 change features priority No functional change expected. This is part of a refactoring to extract parts of ProcessTopBacklogChange into dedicated classes that can be reused in the new PATCH program_increment/$id/content REST route. Notes: I introduce "Stub" classes for some of the interfaces. I'm going to keep repeating the anonymous classes so I figured it was best to have a dedicated Stub class. The goal behind FeatureRemoval's named constructor is to force developers to go through the checks in order to be able to call FeatureRemovalProcessor. The only way to call it is to have a FeatureRemoval, and the only way to build one is to make the verifications. Change-Id: I0e8c95e2321ea068506f6d5b86ae6cc809002f3f

+515 −97
Joris MASSON (jmasson) 2021-04-22 15:27
Joris MASSON (jmasson) 2021-04-23 14:08
de33d2dd2280fc3ea10a5d04b5e35da71c340a0e
0bc93ba4893d094edb65872bb22e34cf99f1e3bb
git #tuleap/stable/de33d2dd2280fc3ea10a5d04b5e35da71c340a0e

Modified Files

Side by side diff
Inline diff
Name
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessor.php +75 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChange.php +36 −50 Go to diff View file
A plugins/program_management/include/Program/Backlog/ProgramIncrement/Content/FeatureRemoval.php +70 −0 Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +7 −3 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +8 −4 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Content/FeatureRemovalProcessorTest.php +139 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/ProcessTopBacklogChangeTest.php +8 −40 Go to diff View file
A plugins/program_management/tests/unit/Program/Backlog/ProgramIncrement/Content/FeatureRemovalTest.php +82 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyIsVisibleFeatureStub.php +43 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyLinkedUserStoryIsNotPlannedStub.php +47 −0 Go to diff View file