Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: UI should not know about link type representations

Download Browse

No functional change expected in the artifact link field. It still shows the list of available link types with only "untyped", "parent" and "child" types. The UI adapter should not know about REST representations. It is the job of the REST adapter. Thus, parsing the REST representation of link types is moved to the REST adapter. It builds domain objects, that the UI adapter displays as HTML. part of story #24970 [modal] select type for links Change-Id: I7cf2d9af8afe45f9bc3b2585c5c1ef053ffa5a44

+222 −165
Joris MASSON (jmasson) 2023-03-08 17:45
Joris MASSON (jmasson) 2023-03-10 09:58
de68d2cee3a9ea63b451c6cb5731f4a61b5008fa
434bcf608ed387f9739764a1f48b9c90d3d0c6b4
git #tuleap/stable/de68d2cee3a9ea63b451c6cb5731f4a61b5008fa

Modified Files

Side by side diff
Inline diff
Name
A plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/fields/link-field/LinkTypesCollector.test.ts +48 −0 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/AllowedLinksTypesCollection.ts Go to diff View file
D plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/AllowedLinksTypesCollection.test.ts +0 −70 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/CollectionOfAllowedLinksTypesPresenters.test.ts +3 −12 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/CollectionOfAllowedLinksTypesPresenters.ts +5 −18 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkField.test.ts +4 −17 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.test.ts +3 −14 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.ts +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.test.ts +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.test.ts +4 −11 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/TypeSelectorTemplate.test.ts +4 −16 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/LinkTypesCollection.test.ts +47 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/LinkTypesCollection.ts +32 −0 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field/CollectAllowedLinksTypes.ts Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/tests/stubs/LinkTypeStub.ts +7 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/LinkTypesCollectionStub.ts +26 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/LinkTypesPairStub.ts +33 −0 Go to diff View file