stable

Clone or download

Read-only

chore: split NewChangesetCreator in smaller classes

part of request #37225 Error affectation Child to Parents artefact after upgrade to 15.6 No functional changes Why? In class ParentLinkAction::linkParent is called inside an event link parent is called from NewChangesetCreator>NewChangesetValidator so we want to be able to create without starting a transaction This patch prepares this changes by spliting NewChangesetCreator in smaller classes to help reusability Change-Id: I7317b8c24c6066f97838b2bd6044b3cc03f6e877

Modified Files

Name
M plugins/gitlab/include/gitlabPlugin.php +76 −61 Go to diff View file
M plugins/kanban/include/Kanban/REST/v1/KanbanResource.php +42 −33 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php +43 −34 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationUpdateProcessorBuilder.php +43 −34 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorBuilder.php +43 −34 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php +43 −34 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +43 −34 Go to diff View file
M plugins/taskboard/include/REST/v1/Card/CardPatcher.php +37 −28 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +37 −28 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +28 −19 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/ExecutionsResource.class.php +29 −20 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +37 −28 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Artifact.php +22 −13 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/ArchiveAndDeleteArtifactTaskBuilder.php +39 −30 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.php +6 −118 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetFieldValueSaver.php +69 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetPostProcessor.php +60 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetValidator.php +90 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/ProcessChangesetPostCreation.php +30 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/StoreNewChangesetFieldValues.php +34 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/ValidateNewChangeset.php +28 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Creation/TrackerArtifactCreator.class.php +36 −27 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImportBuilder.class.php +21 −12 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +21 −12 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +39 −30 Go to diff View file
M plugins/tracker/tests/unit/Stub/Tracker/Artifact/Changeset/PostCreation/PostCreationActionsQueuerStub.php +7 −1 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Artifact/Changeset/ProcessChangesetPostCreationStub.php +51 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Artifact/Changeset/ValidateNewChangesetStub.php +46 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Artifact/ChangesetValue/SaveChangesetValueStub.php +57 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetCreatorTest.php +15 −40 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetFieldValueSaverTest.php +89 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetPostProcessorTest.php +118 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetValidatorTest.php +167 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Tracker_ArtifactTest.php +17 −8 Go to diff View file
M plugins/tracker_functions/include/tracker_functionsPlugin.php +36 −27 Go to diff View file