Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

pull-request comment skeleton when timeline is loading

Download Browse

part of story #31091 Add the hybrid comment to manage comments This contribution introduces a skeleton version of the pullrequest-comment component. I didnt use the tlp-skeleton color because this variable is a RGBa color (RGB + alpha), and, since there are overlapping elements in the component (ex: avatar on followup's border), the opacities sum up, and thus makes the visual rendering terrible. How to test: - When the timeline is loading, the skeleton is displayed. Note: - You can comment the line 140 in OverviewThreads to see it better. Change-Id: I692fb0318758046b1d1a75ba5b6425ae03aa738b

+168 −12
Thomas Gorka (tgorka) 2023-03-06 18:12
Thomas Gorka (tgorka) 2023-03-07 11:59
defd46158b88d20f00ff7c5ccc402d6d3f2ea2d0
8c56d3cc6f68f646f52270ec233d06889edde459
git #tuleap/stable/defd46158b88d20f00ff7c5ccc402d6d3f2ea2d0

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/main.ts +5 −0 Go to diff View file
A plugins/pullrequest/scripts/lib/pullrequest-comments/src/skeleton/PullRequestCommentSkeleton.ts +72 −0 Go to diff View file
A plugins/pullrequest/scripts/lib/pullrequest-comments/themes/includes/_skeleton.scss +82 −0 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/themes/style.scss +2 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.test.ts +5 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.vue +2 −11 Go to diff View file