Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: extract Tracker Fields permissions in dedicated controllers

Download Browse

Decrease complexity of Tracker.class.php and split code path that was managed with a flag (group_first 0/1) into 2 dedicated controllers. I do not intend to touch update. Functional should not change Part of story #13438: display permissions of other groups in fields permissions Change-Id: I20e2e59f49c42154a5b0a2192e7e91d3932f3934

+757 −341
Manuel Vacelet (vaceletm) 2019-06-05 19:50
Manuel Vacelet (vaceletm) 2019-06-07 13:15
e07fb789d9182a51868ad0f9eade2e9bb17ea8a3
22c147d37c8906fa5041470650426a712100e5ac
git #tuleap/stable/e07fb789d9182a51868ad0f9eade2e9bb17ea8a3

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/composer.json +4 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/View/Admin.class.php +7 −8 Go to diff View file
A plugins/tracker/include/Tracker/Permission/PermissionsOnFieldsDisplayByFieldController.php +251 −0 Go to diff View file
A plugins/tracker/include/Tracker/Permission/PermissionsOnFieldsDisplayByGroupController.php +264 −0 Go to diff View file
A plugins/tracker/include/Tracker/Permission/PermissionsOnFieldsUpdateController.php +94 −0 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +3 −264 Go to diff View file
M plugins/tracker/include/trackerPlugin.class.php +31 −4 Go to diff View file
A plugins/tracker/phpunit/Tracker/Permission/PermissionsOnFieldsTests.php +103 −0 Go to diff View file
M plugins/tracker/tests/TrackerTest.php +0 −64 Go to diff View file