Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: New inline comment saves itself

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript New inline comments are saved through FileDiffRestService. Since we want to extract the widget creation part from angular, we need to save the new inline comment differently. [Note] about error display We no longer open the error modal when the POST fails. This modal is opened by an angular service. I'll check with UXD how we are supposed to display errors when they occurs. -- no functional change expected Change-Id: I03105484299335f7bd77fbeafb3cf722587459cc

+256 −108
Thomas Gorka (tgorka) 2022-11-21 11:32
Thomas Gorka (tgorka) 2022-11-23 12:41
e0a36beda236e80d845426bad085bb0b62b5ace6
2e869f379c5b4aa75637fd1c9ec69cd7993088c8
git #tuleap/stable/e0a36beda236e80d845426bad085bb0b62b5ace6

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/app.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.test.ts +1 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.ts +1 −21 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/new-comment-form/NewInlineCommentContext.ts +41 −0 Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/NewInlineCommentForm.test.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/NewInlineCommentForm.ts Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/new-comment-form/NewInlineCommentSaver.test.ts +41 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/new-comment-form/NewInlineCommentSaver.ts +43 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/types.ts +39 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js +21 −41 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +14 −12 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js +8 −8 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff-rest-service.js +0 −21 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentPresenterStub.ts +2 −1 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/SaveNewInlineCommentStub.ts +43 −0 Go to diff View file