stable
Clone or download
Read-only
request #13157: Make sure code does not use deprecated PHP features
PHPCompatibility sniffs are added to the minimal ruleset of Tuleap coding standard. Functions prefixed by a double underscores in the REST API are specifically ignore for now, Restler needs that. Usage of some debug functions in PHPWiki are dropped, they are in non reachable code sections. Tests about hexadecimal number strings are dropped, the feature has been removed since PHP 7 [0] so even if the tested code is modified those specific test cases can not fail. You can use `make phpcs` to test this contribution. [0] https://wiki.php.net/rfc/remove_hex_support_in_numeric_strings Change-Id: I9cf6293e7d384f79dbbe2930ffe7cb61ff677f02
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/REST/AuthenticatedResource.class.php | +3 | −2 | Go to diff View file |
| M | src/common/REST/BasicAuthentication.class.php | +6 | −4 | Go to diff View file |
| M | src/common/REST/TuleapRESTAuthentication.php | +4 | −4 | Go to diff View file |
| M | src/common/admin/Homepage/Controller.php | +1 | −2 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/BlockParser.php | +0 | −6 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/Theme.php | +0 | −3 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/WikiDB.php | +1 | −6 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/XmlElement.php | +2 | −1 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/pear/PEAR.php | +0 | −2 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/plugin/PhpHighlight.php | +0 | −1 | Go to diff View file |
| M | src/composer.json | +1 | −0 | Go to diff View file |
| M | src/composer.lock | +59 | −1 | Go to diff View file |
| M | tests/phpcs/tuleap-ruleset-minimal.xml | +5 | −1 | Go to diff View file |
| M | tests/simpletest/common/valid/Rule_IntTest.php | +5 | −29 | Go to diff View file |