Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Move most of the DAOs of the pull request plugin to prepared statements and PDO

Download Browse

This contribution deals with most of the DAOs of the pull request plugin. Commit 6cd3da6c23e49de955ed942e2c5b54e3808f4929 deals with the main one. The DAO that deals with label is left untouched as it would means to also convert parts of the Tuleap core (transactions are shared between the plugin and the core). This contribution should not change anything at the functionnal level, it is only a technical change leveraging what has been introduced by commit 75c536e1254d78be0792f09c7c15ef6328c64135. This is part of request #11074: Move pull request plugin to prepared statements and PDO Change-Id: I3e216cc67b79a983b8c3d194954112535cb0063e

+66 −98
Thomas Gerbet (tgerbet) 2018-02-01 14:47
Thomas Gerbet (tgerbet) 2018-02-01 14:47
e0efa0847a62427081cb9599bfe71342858ba5d3
20f31b5268eec487ffc9e7e89ee362f13d417274
git #tuleap/stable/e0efa0847a62427081cb9599bfe71342858ba5d3

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Comment/Dao.php +12 −22 Go to diff View file
M plugins/pullrequest/include/PullRequest/InlineComment/Dao.php +29 −39 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reference/ProjectReferenceRetriever.php +2 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reference/ReferenceDao.php +10 −13 Go to diff View file
M plugins/pullrequest/include/PullRequest/Timeline/Dao.php +8 −17 Go to diff View file
M plugins/pullrequest/include/PullRequest/Timeline/Factory.php +5 −5 Go to diff View file