part of story #22675 replicate program increment changes to mirrored program increments How to test: No functional change expected when creating mirror program increments. You can test for non-regression with the end-to-end tests. Notes: With the default settings of our most commonly used IDE PHPStorm, \RuntimeException is considered an "Unchecked" exception. This means that the IDE will *never* warn you that you didn't add a @throws docblock for all exceptions extending it. Some errors legitimately extend it, for example when we retrieve a Tracker from a TrackerIdentifier or when we retrieve a full field from a FieldReference. In those cases, the error indicates something is wrong with either our code logic or our database. However, almost all exceptions in our Domain extend it without good reason. In Synchronized fields, some errors must be caught and dealt with, for example if the Title field is not of type String, we must catch it and show an error message to the user or stop the mirroring. Extending \Exception should be the default, as missing docblocks or try/catch will be flagged by our IDE. Change-Id: I9de2926b3e66c91c525c17323c782d4df0270bb5

+23 −14

Author

Joris MASSON (jmasson) 2021-09-08 15:33

Committer

Joris MASSON (jmasson) 2021-09-09 09:57

Hash e170accce11432e75ba3c628530777133eaef198

Parent 94cc1d766d718ac22d75b7f264ecd6ca42bd41d3

Reference git #tuleap/stable/e170accce11432e75ba3c628530777133eaef198