stable
Clone or download
Read-only
The dependency on IDGenerator implies a verbose API and makes generated XML unncessary complex (hard to read & debug). This first step is about having the possibility to let Tuleap generate the IDs for the fields. The design choice was to rely on Late State Binding (usage of static::) so the implementation can be mutualized in top level classes. It is not possible to have a single implementation in XMLFormElement ATM because we still need XMLFormElementImpl for backward compatibility. It's a small duplication of the logic but the resulting code is more straightward. Finally, there is a need to add dependency on XML tracker in the name generation to ensure uniquness of IDs when several trackers are being generated (import project from jira for instance). IDs are still needed for List fields static values, it will be handeled separately. Part of: request #24247 XML generation intermediate representation should not depend on IDGenerator Change-Id: I1de220467719c3c1d916c93c66ced50e3942e9f0
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/FormElement/Burnup/XML/XMLBurnupField.php | +2 | −6 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/Step/Definition/Field/XML/XMLStepDefinition.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Creation/JiraImporter/Import/AlwaysThereFieldsExporter.php | +17 | −18 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Creation/JiraImporter/Import/JiraXmlExporter.php | +0 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Creation/JiraImporter/Import/Structure/JiraToTuleapFieldTypeMapper.php | +15 | −15 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Container/Column/XML/XMLColumn.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Container/Fieldset/XML/XMLFieldset.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Container/XML/XMLContainer.php | +16 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactId/XML/XMLArtifactIdField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/XML/XMLArtifactLinkField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Burndown/XML/XMLBurndownField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/CrossReference/XML/XMLCrossReferenceField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Date/XML/XMLDateField.php | +3 | −10 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/File/XML/XMLFileField.php | +2 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/FloatingPointNumber/XML/XMLFloatField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Integer/XML/XMLIntegerField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/LastModifiedBy/XML/XMLLastModifiedByField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/LastUpdateDate/XML/XMLLastUpdateDateField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ListFields/XML/XMLMultiSelectBoxField.php | +2 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ListFields/XML/XMLRadioButtonField.php | +2 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ListFields/XML/XMLSelectBoxField.php | +2 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/StringField/XML/XMLStringField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/SubmittedBy/XML/XMLSubmittedByField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/SubmittedOn/XML/XMLSubmittedOnField.php | +2 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Text/XML/XMLTextField.php | +2 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/XML/XMLField.php | +17 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/FieldNameFormatter.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElementFactory.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/XML/XMLFormElement.php | +1 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/XML/XMLTracker.php | +1 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/AlwaysThereFieldsExporterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/Structure/JiraToTuleapFieldTypeMapperTest.php | +0 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/Structure/StoryPointFieldExporterTest.php | +0 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/_fixtures/IXMC/tracker.xml | +126 | −126 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/_fixtures/SBX/tracker.xml | +191 | −191 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Creation/JiraImporter/Import/_fixtures/SP/tracker.xml | +131 | −131 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/FieldNameFormatterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/XML/XMLTrackerTest.php | +16 | −0 | Go to diff View file |