Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add the test status in the representation of the test definitions linked to a backlog item

Download Browse

The test statuses of the test definitions are retrieved in one SQL query. This is more or less a mandatory requirement to not have horrific performances with a real dataset. Indeed, the amount of data to retrieve and filter is not small: all the test executions of the campaigns needs to be intersected with the most recently updated test execution associated with a test definition of a backlog item. The SQL query has room for improvement but the subqueries are not correlated which should be enough to keep the performance of the query decent. Further improvements could be done once we have observed how the query behaves with real production data. However, as a convervative measure, the maximum number of test definitions retrieved at once via the REST endpoint has been lowered. Part of story #14884: Display list of backlog items with their tests definition Change-Id: I1099bdd123e29e5cfabe87b46d2bec979ee89786

+1222 −52
Thomas Gerbet (tgerbet) 2020-06-19 16:19
Thomas Gerbet (tgerbet) 2020-06-23 13:28
e2a7d06ef9bb0150f85f5059af347c7ad93a077d
e76196b420f6166d348e287db742fcf56c243b1d
git #tuleap/stable/e2a7d06ef9bb0150f85f5059af347c7ad93a077d

Modified Files

Side by side diff
Inline diff
Name
M plugins/testplan/include/REST/v1/BacklogItemResource.php +27 −10 Go to diff View file
M plugins/testplan/include/REST/v1/DefinitionLinkedToABacklogItemRepresentation.php +13 −3 Go to diff View file
M plugins/testplan/include/TestDefinition/TestPlanLinkedTestDefinitions.php +6 −3 Go to diff View file
M plugins/testplan/include/TestDefinition/TestPlanLinkedTestDefinitionsRetriever.php +19 −7 Go to diff View file
A plugins/testplan/include/TestDefinition/TestPlanMilestoneInformationNeededToRetrieveTestStatusPerTestDefinition.php +82 −0 Go to diff View file
A plugins/testplan/include/TestDefinition/TestPlanTestDefinitionWithTestStatus.php +71 −0 Go to diff View file
A plugins/testplan/include/TestDefinition/TestPlanTestDefinitionWithTestStatusRetriever.php +86 −0 Go to diff View file
A plugins/testplan/include/TestDefinition/TestPlanTestDefinitionsTestStatusDAO.php +90 −0 Go to diff View file
A plugins/testplan/include/TestDefinition/TestStatusPerTestDefinitionsInformationForUserRetriever.php +148 −0 Go to diff View file
M plugins/testplan/scripts/test-plan/src/store/backlog-item/backlog-item-actions.test.ts +2 −2 Go to diff View file
M plugins/testplan/scripts/test-plan/src/store/backlog-item/backlog-item-actions.ts +2 −1 Go to diff View file
M plugins/testplan/tests/rest/_fixtures/testplan/project.xml +130 −5 Go to diff View file
M plugins/testplan/tests/rest/_fixtures/testplan/testmanagement.xml +3 −0 Go to diff View file
M plugins/testplan/tests/rest/v1/BacklogItemTest.php +14 −10 Go to diff View file
M plugins/testplan/tests/unit/TestDefinition/TestPlanLinkedTestDefinitionsRetrieverTest.php +32 −7 Go to diff View file
M plugins/testplan/tests/unit/TestDefinition/TestPlanLinkedTestDefinitionsTest.php +8 −2 Go to diff View file
A plugins/testplan/tests/unit/TestDefinition/TestPlanTestDefinitionWithTestStatusRetrieverTest.php +120 −0 Go to diff View file
A plugins/testplan/tests/unit/TestDefinition/TestPlanTestDefinitionWithTestStatusTest.php +51 −0 Go to diff View file
A plugins/testplan/tests/unit/TestDefinition/TestStatusPerTestDefinitionsInformationForUserRetrieverTest.php +315 −0 Go to diff View file
M src/common/User/User.class.php +3 −2 Go to diff View file