Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Propagate pagination info to other plugins

Download Browse

Functionally speaking, this should only affect the /trackers/:id/parent_artifacts REST route (pagination works again). The impact of this propagation is larger than initially anticipated. The main changes are, of course in FeatureDao to take into account the new parameters and to have the queries for search and count. Count for pagination was not done, as we usually do with `SQL_CALC_FOUND_ROWS` because it's actually a bad practice and is deprecated in MySQL 8.0 https://dev.mysql.com/worklog/task/?id=12615 Part of story #22681 select a parent from Program for my features/enablers Change-Id: I400b366ae3b1353743e28ae7ce2a919b16aa54ba

+269 −60
Manuel Vacelet (vaceletm) 2021-09-08 09:41
Manuel Vacelet (vaceletm) 2021-09-08 16:09
e3698184bf9d3d470f311394a9b9b93d2ad5f056
2348133bfaddcf9232888546827a21e1af6b40a5
git #tuleap/stable/e3698184bf9d3d470f311394a9b9b93d2ad5f056

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Feature/FeaturesDao.php +66 −8 Go to diff View file
M plugins/program_management/include/Adapter/Team/PossibleParentSelectorProxy.php +18 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/FeaturesStore.php +5 −6 Go to diff View file
M plugins/program_management/include/Domain/Team/PossibleParentHandler.php +17 −15 Go to diff View file
M plugins/program_management/include/Domain/Team/PossibleParentSelectorEvent.php +11 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Team/PossibleParentSelectorProxyTest.php +21 −7 Go to diff View file
M plugins/program_management/tests/unit/Domain/Team/PossibleParentHandlerTest.php +85 −15 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/PossibleParentSelector.php +11 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/PossibleParentsRetriever.php +1 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/PossibleParentsRetrieverTest.php +30 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/PossibleParentSelectorRendererTest.php +4 −4 Go to diff View file