stable
Clone or download
Read-only
request #22691: Editing a changeset comment fallbacks on the synchronous notification system
The issue is caused by the fact we log the entries in a table indexed by a changeset ID and the changeset ID stay the same when we edit a comment. We log those events in order to warn site administrators if we detect something that does not look correct but it is outdated. The tracker plugin is not the only one using the async queue (the pull request plugin does too for example). The mecanism specific to the tracker plugin is removed by this contribution (solving the initial issue) and something more generic working for every usages of the async queue replaces it. Change-Id: Ia38b75dee1da716306fa89eb7664a1f3b1aa3e4f
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tracker/db/install.sql | +0 | −9 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsRunner.php | +0 | −11 | Go to diff View file |
| D | plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsRunnerDao.php | +0 | −70 | Go to diff View file |
| D | plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/AsynchronousSupervisor.php | +0 | −75 | Go to diff View file |
| M | plugins/tracker/include/trackerPlugin.php | +0 | −13 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/ActionsRunnerTest.php | +4 | −13 | Go to diff View file |
| M | src/common/Queue/Noop/PersistentQueue.php | +7 | −0 | Go to diff View file |
| M | src/common/Queue/PersistentQueue.php | +2 | −0 | Go to diff View file |
| A | src/common/Queue/PersistentQueueStatistics.php | +53 | −0 | Go to diff View file |
| A | src/common/Queue/QueueSupervisor.php | +50 | −0 | Go to diff View file |
| M | src/common/Queue/Redis/RedisPersistentQueue.php | +28 | −0 | Go to diff View file |
| M | src/common/system_event/include/SystemEvent_SYSTEM_CHECK.class.php | +10 | −0 | Go to diff View file |
| A | tests/unit/common/Queue/Noop/PersistentQueueTest.php | +41 | −0 | Go to diff View file |
| A | tests/unit/common/Queue/PersistentQueueStatisticsTest.php | +45 | −0 | Go to diff View file |
| A | tests/unit/common/Queue/QueueSupervisorTest.php | +92 | −0 | Go to diff View file |