stable
Clone or download
Read-only
fix: request #39728: If a user does not have access at all to a tracker, it should not be displayed in the backlog
Implementation note: it seems that `testPUTCardsForReadOnlyUser` is broken: bot user cannot access to a private project it is not member of, it does not match the "ReadOnlyUser" in the test name. Now that we check for tracker access for planning before checking artifact access for card, we get a 404 instead of a 403. In order to follow latest development about status code regarding restricted resources, we now return a 404 in case of artifact access denied. Change-Id: Ie99e13aa4a80c34a1e6b6b09fc8d34d1bd886141
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/MilestoneReportCriterionOptionsProvider.class.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Planning/NearestPlanningTrackerProvider.class.php | +4 | −5 | Go to diff View file |
| M | plugins/agiledashboard/include/Planning/PlanningFactory.class.php | +45 | −15 | Go to diff View file |
| A | plugins/agiledashboard/include/Planning/PlanningTrackerNotFoundFault.php | +43 | −0 | Go to diff View file |
| A | plugins/agiledashboard/include/Planning/PlanningTrackerNotReadableFault.php | +42 | −0 | Go to diff View file |
| M | plugins/agiledashboard/include/agiledashboardPlugin.php | +1 | −0 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/MilestoneReportCriterionOptionsProviderTest.php | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/NearestPlanningTrackerProviderTest.php | +4 | −3 | Go to diff View file |
| M | tests/rest/tests/CardsTest.php | +1 | −1 | Go to diff View file |