Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Fix issues detected by Psalm in the SourceArtifactNatureAnalyzer class

Download Browse

The class was introduced on an older version of Psalm which detected those issues under another rule name. The docblock of the Tracker::getId class was fixed to match the reality and pre-existing errors have been integrated into the baseline. Took the opportunity to also fix PFUser::getId which is another big offender of the same issue. Part of story #18405: distinguish Features and P.I. that comes from a Program in a Team Change-Id: I525d1a7e05184eea76b8fdec92c3353991e23599

+314 −337
Thomas Gerbet (tgerbet) 2020-12-08 11:52
Thomas Gerbet (tgerbet) 2020-12-08 12:05
e5e7dbe1e8cd98545ab6ee7eec23c0524e1bdcbf
79a7ebca6d0afe4abe49833fb9b899b4137b99b0
git #tuleap/stable/e5e7dbe1e8cd98545ab6ee7eec23c0524e1bdcbf

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Tracker.class.php +1 −1 Go to diff View file
M src/common/User/User.class.php +1 −1 Go to diff View file
M tests/psalm/tuleap-baseline.xml +312 −335 Go to diff View file