part of story #24969 [modal] add and remove links (replace current artifact link) No functional change expected when creating a new artifact from REST. POST artifacts/:id should still allow those kind of payloads: - {"field_id": 543, "links": [], "parent": {"id": 6486}} - {"field_id": 543, "links": [{"id": 6524}]} - {"field_id": 543, "parent": {"id": 6486}} Conversion from REST value representation is now completely done outside of Tracker_FormElement_Field_ArtifactLink. This will allow us to also recognize reverse links and handle them separately of $fields_data. Only forward links should end up in $fields_data eventually. Separate objects are introduced for Initial changeset case. It has different business rules from "update case", such as "there are no existing links". This produces a cleaner API. For example, in the update scenario, there is always an Artifact, but there is never one in the create scenario. Trying to handle both (as we used to do) forces us to handle nullable parameters and enables cases that shouldn't be possible, for example an "update" payload with no Artifact. It is cleaner (and probably safer) to "Write Everything Twice" in this case. Change-Id: I754f82c7ce4f509ed546b0d4dab5263da5726c4b

+928 −252

Author

Joris MASSON (jmasson) 2022-03-25 17:01

Committer

Joris MASSON (jmasson) 2022-03-25 17:01

Hash e6032efb0218b9bbb58618e4710776efd622a7a3

Parent 0458edd893aaeb4562efba30f7645aa757d9e067

Reference git #tuleap/stable/e6032efb0218b9bbb58618e4710776efd622a7a3