Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: potential content injection in link popover

Download Browse

part of story #38627 : Choice of a new Rich Text Editor Following https://gerrit.tuleap.net/c/tuleap/+/31841/6/lib/frontend/prose-mirror-editor/src/plugins/link-popover/helper/link-popover-inserter.ts#64 The template has been extracted into a hybrids component, allowing us to have a templating engine. Links hrefs are sanitized using the same method used in the project-sidebar (extracted into @tuleap/url-sanitizer). -- No functional change expected. Change-Id: I307952fada5e3d07e9ea94b033bc3fc9f3a0d3e2

+407 −61
Thomas Gorka (tgorka) 2024-09-06 16:26
Thomas Gorka (tgorka) 2024-09-09 11:01
e63b038ddea6de4edbefde9c77380b94c0025441
1e211d8c998a896d011d26e0f1fdfe35212f72f3
git #tuleap/stable/e63b038ddea6de4edbefde9c77380b94c0025441

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/project-sidebar-internal/package.json +1 −0 Go to diff View file
M lib/frontend/project-sidebar-internal/pnpm-lock.yaml +3 −0 Go to diff View file
M lib/frontend/project-sidebar-internal/src/Header/LinkedProjects.vue +1 −1 Go to diff View file
M lib/frontend/project-sidebar-internal/src/Header/SidebarHeader.vue +1 −1 Go to diff View file
M lib/frontend/project-sidebar-internal/src/SidebarLogo.vue +1 −1 Go to diff View file
M lib/frontend/project-sidebar-internal/src/Tools/PromotedItemPresenter.vue +1 −1 Go to diff View file
M lib/frontend/project-sidebar-internal/src/Tools/SubItemPresenter.vue +1 −1 Go to diff View file
M lib/frontend/project-sidebar-internal/src/Tools/ToolPresenter.vue +1 −1 Go to diff View file
M lib/frontend/prose-mirror-editor/package.json +2 −0 Go to diff View file
M lib/frontend/prose-mirror-editor/pnpm-lock.yaml +12 −0 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/link-popover/element/LinkPopoverElement.test.ts +79 −0 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/link-popover/element/LinkPopoverElement.ts +76 −0 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/link-popover/element/LinkPopoverTemplate.test.ts +45 −0 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/link-popover/element/LinkPopoverTemplate.ts +48 −0 Go to diff View file
R lib/frontend/prose-mirror-editor/themes/_link-popover.scss Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/link-popover/helper/link-popover-inserter.test.ts +8 −11 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/link-popover/helper/link-popover-inserter.ts +16 −28 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/link-popover/link-popover.ts +1 −15 Go to diff View file
A lib/frontend/prose-mirror-editor/src/scss-shim.d.ts +23 −0 Go to diff View file
M lib/frontend/prose-mirror-editor/themes/editor.scss +0 −1 Go to diff View file
A lib/frontend/url-sanitizer/.gitignore +1 −0 Go to diff View file
A lib/frontend/url-sanitizer/README.md +12 −0 Go to diff View file
A lib/frontend/url-sanitizer/package.json +27 −0 Go to diff View file
A lib/frontend/url-sanitizer/pnpm-lock.yaml +10 −0 Go to diff View file
R lib/frontend/project-sidebar-internal/src/url-sanitizer.test.ts Go to diff View file
R lib/frontend/project-sidebar-internal/src/url-sanitizer.ts Go to diff View file
A lib/frontend/url-sanitizer/tsconfig.json +7 −0 Go to diff View file
A lib/frontend/url-sanitizer/vite.config.ts +30 −0 Go to diff View file