Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: use standard select behavior for heading select

Download Browse

Usage of heading select does not match the one the user is used to. If I take a Status selectbox, if the current value is Open, then Open is selected. If I select Closed, then Closed is selected. Both are never disabled. We should apply the same principle here: * If I highlight a h1 title in the description, then h1 is selected (and not disabled) * If I change to h2, then the highlighted section is now an h2 * If I do not change the selection and click on the same value than before, then nothing is changed in the editor. This is something that has been spotted after the review of contribution gerrit #32112 has been completed. Part of story #38627: Choice of a new Rich Text Editor Change-Id: If57899ea3667e917873e8222f16ae10af97463c1

+34 −5
Nicolas Terray (nterray) 2024-10-16 18:06
Nicolas Terray (nterray) 2024-10-16 18:23
e7a4e2d2e004fbf1d8eec6a2a590da39242ba6dc
d37ee19111bcf25d716ed01cfdbf12f5b7381ff1
git #tuleap/stable/e7a4e2d2e004fbf1d8eec6a2a590da39242ba6dc

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/text-style/heading-option-template.test.ts +15 −2 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/text-style/heading-option-template.ts +4 −1 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/text-style/plain-text-option-template.test.ts +11 −1 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/text-style/plain-text-option-template.ts +4 −1 Go to diff View file