Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: regroup getCriteriaFrom and getCriteriaWhere

Download Browse

Since we have parametrized FromWhere at our disposal, we don't need anymore to have distinctive calls to retrieve the from and the where of a criterion. We now have the different SQL fragment at the same place (mostly), this avoid to go back and forth between the construction of the from and the where to understand what's going on. No functional changes Note: Some issues have been fixed during development of this refactoring (extra placeholder in Integer query, missing spread operator in Float 😭). This will probably have to be backported. Closes request #32643: regroup getCriteriaFrom and getCriteriaWhere Change-Id: Ic48c536e1cb0a1124fb3e043c5736bc6b5b7a33a

+802 −587
Nicolas Terray (nterray) 2023-06-22 15:51
Nicolas Terray (nterray) 2023-06-23 15:33
ea4002c1ccc919455fa6656bd8679c1a7f4b408d
b468911c813c1aee8aa57ed82242b5760a6263f7
git #tuleap/stable/ea4002c1ccc919455fa6656bd8679c1a7f4b408d

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/FormElement/Burnup.php +3 −9 Go to diff View file
M plugins/testmanagement/include/TestManagement/Step/Definition/Field/StepDefinition.php +3 −9 Go to diff View file
M plugins/testmanagement/include/TestManagement/Step/Execution/Field/StepExecution.php +3 −9 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.php +3 −13 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactId.php +11 −10 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php +40 −32 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Burndown.php +3 −9 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Computed.php +3 −9 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_CrossReferences.php +20 −18 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Date.php +37 −35 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_File.php +27 −25 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Float.php +31 −30 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Integer.php +31 −36 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_LastModifiedBy.php +19 −5 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_LastUpdateDate.php +21 −22 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List.php +5 −14 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind.php +44 −77 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Null.php +3 −9 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_OpenList.php +46 −41 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_PerTrackerArtifactIdclass.php +12 −4 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_PermissionsOnArtifact.php +34 −32 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Priority.php +16 −15 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_SubmittedBy.php +19 −6 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_SubmittedOn.php +22 −22 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Text.php +33 −33 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/ParametrizedAndFromWhere.php +8 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/ParametrizedOrFromWhere.php +8 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +3 −18 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report_Criteria.class.php +4 −13 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_CriteriaTest.php +3 −9 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_FloatTest.php +4 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_IntegerTest.php +4 −4 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/ParametrizedAndFromWhereTest.php +135 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/ParametrizedOrFromWhereTest.php +141 −6 Go to diff View file
M plugins/tracker_encryption/include/Tracker_FormElement_Field_Encrypted.class.php +3 −9 Go to diff View file