In git #tuleap/stable/92ecfef184b4ec04429c2cad871ffb40a8e2c76c, we introduced a new param for `BaseLayout::header()`: `active-promoted-item-id`. We did it this way because it was the fastest way to deliver the feature. However we should stop relying on an associative array to pass variables to `header()`. Therefore, in order to leave the place cleaner than we found it 🚽, we start removing unneeded variables and move other ones in `HeaderConfiguration` classes. The current contribution focuses on `user_has_special_access` which is only used by ServiceTracker. By moving the underlying condition, we can reduce the `$params` mess with a baby step. We introduce a usage of `session_require()` call in ServiceTracker which is not great, but refactoring this should be a dedicated contribution. Bonus: the check of global tracker administrator was broken (I didn't manage to know for how long). It is now fixed: users not members of project, can access trackers if they have Global Tracker Administrator permission delegation. Part of story #34002: see promoted trackers in sidebar Change-Id: Ibdd47bd780417972b633d66d20e2230b7ffd6983

+57 −57

Author

Nicolas Terray (nterray) 2023-09-25 16:43

Committer

Nicolas Terray (nterray) 2023-09-26 12:36

Hash eb50f3a557253b9d326063f8f8b5e9912312f92f

Parent afc3585d981e3537acc3712bfe83ff68d96c8304

Reference git #tuleap/stable/eb50f3a557253b9d326063f8f8b5e9912312f92f