stable

Clone or download

Read-only

Remove \user_getid() function

The function is marked as deprecated since 2017. Since the upgrade to Psalm 3.4.5 it is also responsible for a non negligeable part of the issues found when a subpart of the codebase is analyzed (see the attached file in the request). The change affects some site-content files so a note in the deployment guide will need to be added. Part of request #13292: Integrate vimeo/psalm to the test pipeline Change-Id: I2cdd987d945e14c1fb2fe661d936071e9cf0f716

Modified Files

Name
M plugins/docman/include/Docman_ItemFactory.class.php +2 −2 Go to diff View file
M plugins/docman/include/Docman_Widget_MyEmbedded.class.php +2 −2 Go to diff View file
M plugins/forumml/include/forumml_utils.php +3 −1 Go to diff View file
M plugins/graphontrackers/include/data-access/GraphOnTrackers_Chart_Bar.class.php +9 −7 Go to diff View file
M plugins/graphontrackers/include/data-access/GraphOnTrackers_Chart_Gantt.class.php +15 −12 Go to diff View file
M plugins/graphontrackers/include/data-access/GraphOnTrackers_Chart_Pie.class.php +7 −6 Go to diff View file
M plugins/graphontrackers/include/graphontrackersPlugin.class.php +3 −3 Go to diff View file
M plugins/graphontrackersv5/include/GraphOnTrackersV5_Widget_MyChart.class.php +2 −2 Go to diff View file
M plugins/ldap/include/ldapPlugin.class.php +1 −1 Go to diff View file
M src/common/Project/Group.class.php +4 −3 Go to diff View file
M src/common/Project/ProjectCreator.class.php +1 −1 Go to diff View file
M src/common/Widget/Widget_MyArtifacts.class.php +2 −2 Go to diff View file
M src/common/Widget/Widget_MyBookmarks.class.php +2 −2 Go to diff View file
M src/common/Widget/Widget_MyImageViewer.class.php +7 −6 Go to diff View file
M src/common/Widget/Widget_MyMonitoredForums.class.php +2 −2 Go to diff View file
M src/common/Widget/Widget_MyMonitoredFp.class.php +2 −2 Go to diff View file
M src/common/Widget/Widget_MyProjects.class.php +1 −1 Go to diff View file
M src/common/Widget/Widget_MyRss.class.php +2 −2 Go to diff View file
M src/common/dao/ProjectHistoryDao.class.php +2 −2 Go to diff View file
M src/common/frs/FRSFile.class.php +4 −2 Go to diff View file
M src/common/frs/ServiceFile.class.php +7 −6 Go to diff View file
M src/common/html/HTML_Element_Selectbox_TrackerFields_Dates.class.php +7 −6 Go to diff View file
M src/common/html/HTML_Element_Selectbox_TrackerFields_Int_TextFields.class.php +7 −6 Go to diff View file
M src/common/html/HTML_Element_Selectbox_TrackerFields_Numerics.class.php +7 −6 Go to diff View file
M src/common/html/HTML_Element_Selectbox_TrackerFields_Selectboxes.class.php +7 −6 Go to diff View file
M src/common/html/HTML_Element_Selectbox_TrackerFields_Texts.class.php +7 −6 Go to diff View file
M src/common/include/GroupFactory.class.php +3 −1 Go to diff View file
M src/common/reference/ReferenceManager.class.php +1 −1 Go to diff View file
M src/common/search/SearchTrackerV3.class.php +1 −1 Go to diff View file
M src/common/tracker/Artifact.class.php +19 −18 Go to diff View file
M src/common/tracker/ArtifactFile.class.php +1 −1 Go to diff View file
M src/common/tracker/ArtifactType.class.php +6 −6 Go to diff View file
M src/common/tracker/HTML/ArtifactHtml.class.php +1 −1 Go to diff View file
M src/common/tracker/HTML/ArtifactReportHtml.class.php +2 −2 Go to diff View file
M src/common/wiki/WikiService.class.php +3 −3 Go to diff View file
M src/common/wiki/lib/WikiAttachment.class.php +8 −7 Go to diff View file
M src/common/wiki/phpwiki/lib/WikiUser/Codendi.php +7 −6 Go to diff View file
M src/common/wiki/phpwiki/lib/plugin/UpLoad.php +1 −1 Go to diff View file
M src/common/wiki/views/WikiServiceViews.class.php +3 −3 Go to diff View file
M src/www/account/change_pw.php +1 −1 Go to diff View file
M src/www/account/change_timezone.php +2 −2 Go to diff View file
M src/www/account/updateprefs.php +2 −2 Go to diff View file
M src/www/cvs/index.php +1 −1 Go to diff View file
M src/www/forum/admin/index.php +1 −1 Go to diff View file
M src/www/forum/forum.php +3 −2 Go to diff View file
M src/www/forum/forum_utils.php +14 −10 Go to diff View file
M src/www/forum/monitor.php +8 −7 Go to diff View file
M src/www/forum/monitor_thread.php +7 −5 Go to diff View file
M src/www/forum/save.php +6 −4 Go to diff View file
M src/www/include/bookmarks.php +7 −4 Go to diff View file
M src/www/include/session.php +3 −2 Go to diff View file
M src/www/include/user.php +7 −11 Go to diff View file
M src/www/include/viewvc_utils.php +6 −6 Go to diff View file
M src/www/mail/admin/index.php +4 −4 Go to diff View file
M src/www/my/bookmark_edit.php +2 −2 Go to diff View file
M src/www/my/rmproject.php +1 −1 Go to diff View file
M src/www/my/stop_monitor.php +5 −4 Go to diff View file
M src/www/news/news_utils.php +4 −2 Go to diff View file
M src/www/soap/tracker/tracker.php +14 −13 Go to diff View file
M src/www/tracker/add.php +1 −1 Go to diff View file
M src/www/tracker/admin/index.php +9 −7 Go to diff View file
M src/www/tracker/browse.php +6 −5 Go to diff View file
M src/www/tracker/detail.php +1 −1 Go to diff View file
M src/www/tracker/export.php +2 −2 Go to diff View file
M src/www/tracker/import_admin.php +2 −2 Go to diff View file
M src/www/tracker/index.php +8 −7 Go to diff View file
M src/www/tracker/mod.php +1 −1 Go to diff View file
M src/www/wiki/uploads.php +1 −1 Go to diff View file