stable

Clone or download

Read-only

chore: build tracker styles separately

closes request #29264 Split the build of tracker plugin frontend assets into multiple apps How to test: No functional change: - Tracker FlamingParrot and BurningParrot pages should still load their CSS styles. - In Tracker Admin > Workflow > Field Dependencies, the CSS style of the matrix table should still be loaded. - CSS styles for Print mode (add "&pv=1" in Artifact view) should still be loaded. Notes: While we use CSSViteAssets in the event handler for cssFile(), we cannot use Layout::addCssAsset because it is too late in the execution. It looks like the HTML for the header has already been sent, using addCssAsset at this point has no result. Improving the loading of the CSS (by not using global events for a start) should be a separate effort, the situation should not be worse with this patch. Note that due to the API, we are forced to build a useless ThemeVariation. It is discarded by CSSViteAsset. This also corrects a mistake I made when setting up vite configurations in Tracker. Due to ad-blockers filtering "assets/tracker/", we have used a workaround "assets/trackers/" public path for Tracker. It means we cannot use the basename of the plugin folder, so we just use "trackers" magic string. It has not caused problems until now because we were not using dynamic import, but CSS styles import some loader images, and they will fail to load without this. I took the opportunity to fix the mistake everywhere. There are still images remaining in themes/default/images/ folder. This is intended: they are used in an email template. I did not want to try and see what happens if we move them: they are never used in CSS. Change-Id: I56781e7385645182ac228f42245a03feb1840622

Modified Files

Name
M plugins/tracker/include/Tracker/Report/Tracker_Report_Renderer_Table.class.php +6 −5 Go to diff View file
M plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php +9 −10 Go to diff View file
M plugins/tracker/include/Tracker/Widget/Tracker_Widget_MyArtifacts.class.php +6 −5 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +28 −10 Go to diff View file
M plugins/tracker/scripts/global-admin/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/header/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/move-artifact-action/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/permissions-per-group/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/report/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/semantics-timeframe/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/service-homepage/vite.config.ts +1 −1 Go to diff View file
M plugins/tracker/scripts/site-admin/vite.config.ts +1 −1 Go to diff View file
R plugins/tracker/package.json Go to diff View file
R plugins/tracker/pnpm-lock.yaml Go to diff View file
R plugins/tracker/themes/BurningParrot/css/includes/_administration.scss Go to diff View file
R plugins/tracker/themes/BurningParrot/css/includes/_email-copy-paste.scss Go to diff View file
R plugins/tracker/themes/BurningParrot/css/includes/_project-tracker-background.scss Go to diff View file
R plugins/tracker/themes/BurningParrot/css/includes/_semantics.scss Go to diff View file
R plugins/tracker/themes/BurningParrot/css/includes/_widgets.scss Go to diff View file
R plugins/tracker/themes/BurningParrot/css/tracker.scss Go to diff View file
R plugins/tracker/themes/FlamingParrot/css/_tracker-creation.scss Go to diff View file
R plugins/tracker/themes/FlamingParrot/css/dependencies-matrix.scss Go to diff View file
R plugins/tracker/themes/FlamingParrot/css/style.scss Go to diff View file
R plugins/tracker/themes/default/css/style.scss Go to diff View file
R plugins/tracker/themes/default/images/button-gradient-hover.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/button-gradient.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/drag.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/gradient-white.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/arrow-turn-090-left.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/artifact-plus.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/bullet_green.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/bullet_grey.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/ci_build/server.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/cross-disabled.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/cross.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/information-small-white.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/spinner.gif Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/tick-grey.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/tick.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/tracker_renderer_table-faded.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/tracker_renderer_table.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/ui-text-field--exclamation-red.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/ic/ui-text-field-change.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/pointer_down.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/tracker_admin_static_value_hidden.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/tracker_report_query_bg.png Binary file Go to diff View file
R plugins/tracker/themes/default/images/tree.png Binary file Go to diff View file
R plugins/tracker/themes/default/css/includes/_artifact-link-field.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_cards.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_cross-references-fields.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_field-bound-colors.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_move-artifact.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_project-header-background.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_xml-changesets.scss Go to diff View file
R plugins/tracker/themes/default/css/includes/_xml-validation.scss Go to diff View file
R plugins/tracker/themes/default/css/print.scss Go to diff View file
A plugins/tracker/scripts/styles/vite.config.ts +43 −0 Go to diff View file
D plugins/tracker/webpack.common.js +0 −45 Go to diff View file
D plugins/tracker/webpack.dev.js +0 −23 Go to diff View file
D plugins/tracker/webpack.prod.js +0 −23 Go to diff View file