Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Prevent browser to leave page during edition

Download Browse

When users start to edit an artidoc, the browser should ask them for confirmation before losing the current changes. The confirmation should be displayed as soon as there is at least one editor open. Took the opportunity to homogeneize the public api of useSectionEditor: instead of having a `cancelEditor()` and a `setEditMode(true)` we now have `cancelEditor()` and `enableEditor()`. Naming is more consistent and the parameter was always true publicly. Part of story #37543: edit Artidoc sections Change-Id: I3694e9da61ecded1d453bc6fec63818d153879e1

+127 −8
Nicolas Terray (nterray) 2024-05-21 13:53
Nicolas Terray (nterray) 2024-05-21 18:15
ed2293873396fb5791b589b092a87c98690f4d8b
8b4c71cca186e4a4a8dd8626922e99bcd387e245
git #tuleap/stable/ed2293873396fb5791b589b092a87c98690f4d8b

Modified Files

Side by side diff
Inline diff
Name
M plugins/artidoc/scripts/artidoc/src/components/SectionEditorCta.test.ts +1 −1 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/SectionEditorCta.vue +2 −2 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/composables/useSectionEditor.test.ts +68 −3 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/composables/useSectionEditor.ts +26 −2 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/helpers/on-before-unload.ts +30 −0 Go to diff View file