stable
Clone or download
Read-only
part of request #39022 Moving a card in Taskboard can have side effects No functional change. Unit and REST tests should pass. Why? This series of refactorings has the goal to make it easy to write a "domain" API to find the current column of a given card. This requires us to know the list of columns of the affected taskboard. Removed the two inheritor classes of ColumnCollection, as the visitor they implemented was not called anymore. Change-Id: If3c24c8bb6a71a85ce0960b74f9b86198c5fc275
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/cardwall/include/Board.class.php | +4 | −2 | Go to diff View file |
| M | plugins/cardwall/include/Cardwall_Renderer.class.php | +2 | −1 | Go to diff View file |
| M | plugins/cardwall/include/Column/ColumnColorRetriever.php | +3 | −1 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/Config.class.php | +10 | −8 | Go to diff View file |
| R | plugins/cardwall/include/OnTop/Config/ColumnCollection.class.php | Go to diff View file | ||
| R | plugins/cardwall/include/OnTop/Config/ColumnFactory.class.php | Go to diff View file | ||
| D | plugins/cardwall/include/OnTop/Config/ColumnFreestyleCollection.class.php | +0 | −31 | Go to diff View file |
| D | plugins/cardwall/include/OnTop/Config/ColumnStatusCollection.class.php | +0 | −31 | Go to diff View file |
| D | plugins/cardwall/include/OnTop/Config/ColumnsVisitor.class.php | +0 | −29 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/Config/TrackerMappingFactory.class.php | +4 | −3 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/Config/ValueMappingFactory.class.php | +3 | −1 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/Config/View/Admin.class.php | +0 | −5 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/ConfigEmpty.class.php | +8 | −7 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/ConfigFactory.class.php | +3 | −1 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/IConfig.class.php | +3 | −2 | Go to diff View file |
| M | plugins/cardwall/include/Pane.class.php | +2 | −1 | Go to diff View file |
| M | plugins/cardwall/include/PaneBoardBuilder.class.php | +6 | −5 | Go to diff View file |
| M | plugins/cardwall/include/RawBoardBuilder.class.php | +3 | −2 | Go to diff View file |
| M | plugins/cardwall/include/RendererBoardBuilder.class.php | +4 | −2 | Go to diff View file |
| M | plugins/cardwall/include/SingleCardBuilder.class.php | +3 | −2 | Go to diff View file |
| M | plugins/cardwall/include/SwimlineFactory.class.php | +3 | −1 | Go to diff View file |
| M | plugins/cardwall/include/UserPreferences/UserPreferencesAutostackFactory.class.php | +4 | −2 | Go to diff View file |
| M | plugins/cardwall/tests/unit/CardwallConfigXmlExport_ColumnsTest.php | +4 | −4 | Go to diff View file |
| M | plugins/cardwall/tests/unit/Cardwall_Column_isInColumnTest.php | +4 | −4 | Go to diff View file |
| M | plugins/cardwall/tests/unit/Cardwall_PaneBuilderTest.php | +3 | −3 | Go to diff View file |
| M | plugins/cardwall/tests/unit/Cardwall_SwimLineFactoryTest.php | +6 | −7 | Go to diff View file |
| M | plugins/cardwall/tests/unit/Column/ColumnColorRetrieverTest.php | +3 | −1 | Go to diff View file |
| M | plugins/cardwall/tests/unit/OnTop/Cardwall_OnTop_ConfigTest.php | +11 | −6 | Go to diff View file |
| M | plugins/cardwall/tests/unit/OnTop/Config/Cardwall_OnTop_Config_TrackerMappingFactoryTest.php | +2 | −3 | Go to diff View file |
| M | plugins/cardwall/tests/unit/OnTop/Config/Cardwall_OnTop_Config_ValueMappingFactoryTest.php | +1 | −2 | Go to diff View file |
| M | plugins/cardwall/tests/unit/OnTop/Config/ColumnFactoryTest.php | +7 | −13 | Go to diff View file |
| M | plugins/cardwall/tests/unit/Test/Builders/ColumnTestBuilder.php | +3 | −1 | Go to diff View file |
| M | plugins/taskboard/include/Column/ColumnPresenterCollectionRetriever.php | +4 | −4 | Go to diff View file |
| M | plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php | +4 | −4 | Go to diff View file |
| M | plugins/taskboard/tests/unit/Column/ColumnPresenterCollectionRetrieverTest.php | +36 | −38 | Go to diff View file |
| M | plugins/taskboard/tests/unit/REST/v1/Cell/CardMappedFieldUpdaterTest.php | +3 | −3 | Go to diff View file |
| M | tests/psalm/tuleap-baseline.xml | +1 | −70 | Go to diff View file |