Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Have an endpoint to find potential reviewers of a pull request

Download Browse

The autocompleter now only returns users that can actually be added as reviewers. You can test it by calling directly GET /plugins/pullrequest/autocompleter_reviewers/{pull_request_id}?name={name_to_search} or by playing with the autocompleter. Part of story #14190: get email notifications on pull requests - first stage Change-Id: Idcaa6d8f78a172d53e4e240bf1c03ecb4dfd33f7

+883 −21
Thomas Gerbet (tgerbet) 2019-11-26 15:15
Thomas Gerbet (tgerbet) 2019-11-27 11:08
ed90dec7d0435ec46f7454eae51a6a9068d10fa3
9807ee39e3aa5712fdb59f05ea72eda9f48f7eaf
git #tuleap/stable/ed90dec7d0435ec46f7454eae51a6a9068d10fa3

Modified Files

Side by side diff
Inline diff
Name
A plugins/pullrequest/include/PullRequest/Reviewer/Autocompleter/PotentialReviewerRetriever.php +105 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/Reviewer/Autocompleter/ReviewerAutocompleterController.php +131 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/Reviewer/Autocompleter/UsernameToSearch.php +59 −0 Go to diff View file
A plugins/pullrequest/include/PullRequest/Reviewer/Autocompleter/UsernameToSearchTooSmallException.php +53 −0 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +49 −15 Go to diff View file
A plugins/pullrequest/phpunit/Reviewer/Autocompleter/PotentialReviewerRetrieverTest.php +139 −0 Go to diff View file
A plugins/pullrequest/phpunit/Reviewer/Autocompleter/ReviewerAutocompleterControllerTest.php +175 −0 Go to diff View file
A plugins/pullrequest/phpunit/Reviewer/Autocompleter/UsernameToSearchTest.php +43 −0 Go to diff View file
M plugins/pullrequest/www/scripts/src/app/overview/reviewers/reviewers-rest-service.js +6 −2 Go to diff View file
M plugins/pullrequest/www/scripts/src/app/overview/reviewers/reviewers-service.test.js +2 −2 Go to diff View file
M plugins/pullrequest/www/scripts/src/app/overview/reviewers/update-reviewers-modal/update-reviewers-modal-controller.js +1 −1 Go to diff View file
A src/common/Http/Response/JSONResponseBuilder.php +61 −0 Go to diff View file
M src/common/dao/UserDao.class.php +5 −1 Go to diff View file
A tests/phpunit/common/Http/Response/JSONResponseBuilderTest.php +54 −0 Go to diff View file