Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Insert both milestone and not milestone trackers

Download Browse

No functional change. $ make tests-db SEED=1707916390 The command above should pass Why? - The test used a fixed tracker ID of 25 for milestone tracker, but if other tests insert 24 trackers before this one, then the "not milestone" tracker will also have ID = 25, which makes the test fail. To avoid that, we should insert both the "milestone" and the "not milestone" trackers, so they can never have the same ID. - I also took the opportunity of adding an assertion for the dao->delete(). fixes request #36829 PlanningDAO test is flaky Change-Id: I79be3f88767117758783c3f3d9ad2ffa9eb2578d

+10 −23
Joris MASSON (jmasson) 2024-02-15 16:52
Joris MASSON (jmasson) 2024-02-15 16:52
ef7315384464c827e18beffcdf2347f6bc8fa6b3
ecdeea3153c56bd535b35b1faf0d2fe63e080781
git #tuleap/stable/ef7315384464c827e18beffcdf2347f6bc8fa6b3

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/tests/integration/Planning/PlanningDAOTest.php +10 −23 Go to diff View file