Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Stop relying on the the god PullRequest/Factory class in reviewer part

Download Browse

Use the dedicated class instead a god factory to retrieve a pull request by its id. No functional change expected, you can still add reviewers to your pull request as before request #35473 Stop relying on the god PullRequest/Factory class to retrieve pull request Change-Id: I0b98301b764c9ed25d2ab843d301d45b2aeaec70

+131 −212
Clarck Robinson (robinsoc) 2023-12-05 17:06
Clarck Robinson (robinsoc) 2023-12-11 16:57
f040a7afb8a6a49db416da2752d09ecb9f9a9810
0275f11666e6a2ce85c254e21774125188afc7b5
git #tuleap/stable/f040a7afb8a6a49db416da2752d09ecb9f9a9810

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Notification/PullRequestNotificationSupport.php +1 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +1 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/Autocompleter/ReviewerAutocompleterController.php +42 −69 Go to diff View file
M plugins/pullrequest/include/PullRequest/Reviewer/Change/ReviewerChangeRetriever.php +15 −33 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +1 −1 Go to diff View file
M plugins/pullrequest/tests/unit/Reviewer/Autocompleter/ReviewerAutocompleterControllerTest.php +35 −52 Go to diff View file
M plugins/pullrequest/tests/unit/Reviewer/Change/ReviewerChangeRetrieverTest.php +36 −54 Go to diff View file