Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add help block handling to the Image upload form lib

Download Browse

Part of story #18336 add support of markdown How to test: - rebuild tuleap core - No functional change in Image drag/drop feature in the Tracker Artifact view. It does not affect the Artifact modal. Notes: The HelpBlock creation is not used by RichTextEditor.js in order to avoid making too many changes in it. It will be used by a later contribution that aims to replace RichTextEditor. It is pushed in this patch in order to reduce the size of the next contribution and ease review. Using a factory instead of top-level functions as before is just to avoid doing the gettext init multiple times per RichTextEditor instance. Change-Id: Ia4f6d8be143b353216a7b3ec9eebc28d979d133c

+278 −135
Joris MASSON (jmasson) 2021-01-29 09:34
Joris MASSON (jmasson) 2021-01-29 09:54
f10ee7c221118b9d223c28333cde069aa90e3abb
95fdf2314ae92c7f18ef55fecc110d1455ca1649
git #tuleap/stable/f10ee7c221118b9d223c28333cde069aa90e3abb

Modified Files

Side by side diff
Inline diff
Name
M src/scripts/codendi/RichTextEditor.js +7 −4 Go to diff View file
M src/scripts/lib/ckeditor-image-upload-form/README.md +11 −1 Go to diff View file
M src/scripts/lib/ckeditor-image-upload-form/package.json +1 −0 Go to diff View file
A src/scripts/lib/ckeditor-image-upload-form/src/HelpBlock.js +35 −0 Go to diff View file
A src/scripts/lib/ckeditor-image-upload-form/src/HelpBlock.test.js +46 −0 Go to diff View file
R src/scripts/lib/ckeditor-image-upload-form/src/HelpBlockTranslator.js Go to diff View file
A src/scripts/lib/ckeditor-image-upload-form/src/HelpBlockFactory.test.js +82 −0 Go to diff View file
D src/scripts/lib/ckeditor-image-upload-form/src/HelpBlockTranslator.test.js +0 −86 Go to diff View file
M src/scripts/lib/ckeditor-image-upload-form/src/Initializer.js +1 −4 Go to diff View file
M src/scripts/lib/ckeditor-image-upload-form/src/Initializer.test.js +7 −22 Go to diff View file
A src/scripts/lib/ckeditor-image-upload-form/src/UploadImageFormFactory.js +42 −0 Go to diff View file
A src/scripts/lib/ckeditor-image-upload-form/src/ckeditor-image-upload-form.d.ts +45 −0 Go to diff View file
M src/scripts/lib/ckeditor-image-upload-form/src/index.js +1 −18 Go to diff View file