Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #17089: Remove (for real) timer input from the test execution display

Download Browse

In c4866f6b22ec20007fe277cf784f17fe1d8d331e this timer was supposedly removed but the commit message was lying the timer was just hidden. This contribution takes care of removing the code. Enabling and disabling the "saving" status of a test execution has been relocated in the controller to be sure the change back to the non saving mode is correctly detected even where there is no change on the execution itself. It also makes the mechanism easier to reason about as the switch between the saving and non-saving modes is local instead of being splitted between the controller and the service. Change-Id: I1a042cf4570cf0365f24a0f589dadb8d6ed04bb1

+9 −136
Thomas Gerbet (tgerbet) 2020-09-22 22:41
Thomas Gerbet (tgerbet) 2020-09-23 14:18
f1dd1d68e97abb3f5027bbbdf311a39a604b2ade
bd6da179c26fedf46cfdba13e95fc65b9fc03851
git #tuleap/stable/f1dd1d68e97abb3f5027bbbdf311a39a604b2ade

Modified Files

Side by side diff
Inline diff
Name
M plugins/testmanagement/scripts/testmanagement/src/execution-collection/execution-rest-service.js +1 −5 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution-collection/execution-rest-service.test.js +1 −2 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution-collection/execution-service.js +0 −3 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution/execution-detail-controller.js +2 −22 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution/execution-detail-controller.test.js +5 −17 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution/execution-detail.tpl.html +0 −2 Go to diff View file
M plugins/testmanagement/scripts/testmanagement/src/execution/execution.js +0 −2 Go to diff View file
D plugins/testmanagement/scripts/testmanagement/src/execution/timer/execution-timer-directive.js +0 −70 Go to diff View file
D plugins/testmanagement/scripts/testmanagement/src/execution/timer/execution-timer-directive.tpl.html +0 −9 Go to diff View file
M plugins/testmanagement/themes/BurningParrot/css/includes/_current-execution.scss +0 −4 Go to diff View file