Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #13949 Legacy notification link do not properly redirect user

Download Browse

How to reproduce: Make sure your user preference is plugin_docman_display_new_ui_<project_id> not set. Forge an url and access to plugins/docman/?group_id=XXXX&id=YYYY - if param "id" is your root folder, you should be redirected on root_homepage - else you should be redirected in preview of given item This kind of url are used by notifications, when user click on a legacy notification, he should be properly redirected, that means we have the same behavior and user preferences are ignored here. We will always redirect user on "new" ui. Change-Id: I7fda67858725c98fa91905b521eba4daf1d9cc29

+152 −26
Marie Ange Garnier (marieange) 2019-09-30 15:04
Marie Ange Garnier (marieange) 2019-10-02 16:04
f21be98457092d3a288791b723d436005a1b1275
932aabd23406f4efe04e3c18068921013d999d81
git #tuleap/stable/f21be98457092d3a288791b723d436005a1b1275

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/DocmanLegacyController.php +9 −2 Go to diff View file
M plugins/docman/include/ExternalLinks/DocmanHTTPControllerProxy.php +16 −2 Go to diff View file
M plugins/docman/include/ExternalLinks/ExternalLinkRedirector.php +46 −11 Go to diff View file
M plugins/docman/include/docmanPlugin.php +8 −6 Go to diff View file
M plugins/docman/phpunit/ExternalLinks/ExternalLinkRedirectorTest.php +73 −5 Go to diff View file