stable

Clone or download

Read-only

Refactoring: Primitive obsession with available natures

Instead of having available natures as associtive arrays: {keyword: string, icon: string, label: string} we use a plain object. That way it is easier to navigate in keyword|icon|label usages and we are sure that a plugin does not forget to add a key like icon when it gaves its nature. Part of story #17180 take into account gitlab commits Change-Id: I7623de96d5e4f3f36a0323710fee3408c6edca51

Modified Files

Name
M plugins/bugzilla_reference/include/bugzilla_referencePlugin.php +6 −5 Go to diff View file
M plugins/git/include/gitPlugin.php +6 −5 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +6 −5 Go to diff View file
M plugins/hudson/include/hudsonPlugin.php +11 −10 Go to diff View file
M plugins/pullrequest/include/pullrequestPlugin.php +4 −5 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +2 −5 Go to diff View file
M src/common/Event/Event.class.php +1 −2 Go to diff View file
M src/common/Project/Admin/Reference/ReferenceAdministrationViews.php +7 −4 Go to diff View file
M src/common/Reference/CrossReferenceByDirectionPresenterBuilder.php +1 −1 Go to diff View file
M src/common/Reference/CrossReferenceByNatureOrganizer.php +4 −4 Go to diff View file
A src/common/Reference/Nature.php +51 −0 Go to diff View file
M src/common/reference/CrossReferenceByNatureCollection.php +3 −3 Go to diff View file
M src/common/reference/CrossReferenceFactory.class.php +1 −1 Go to diff View file
M src/common/reference/ReferenceManager.class.php +60 −61 Go to diff View file
M tests/unit/common/Reference/CrossReferenceByDirectionPresenterBuilderTest.php +2 −2 Go to diff View file
M tests/unit/common/Reference/CrossReferenceByNatureOrganizerTest.php +13 −13 Go to diff View file