Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add typehinting for transitions class

Download Browse

part of request #25696 Workflow can be broken due to deleted values in transition It typehint the class for actual codebase: from and to values can be null In next patch I'll correct the type to make to value non nullable No functional change Change-Id: I0ad16a8ea50d932b3971552ee821b892e97513c7

+33 −48
Marie Ange Garnier (marieange) 2022-03-16 16:18
Marie Ange Garnier (marieange) 2022-03-18 10:19
f2b4b55434d59ad13f3241be1f6e04d3f0df457e
fdc1a2444dc7188303e5c87f5327406c7eb21c2b
git #tuleap/stable/f2b4b55434d59ad13f3241be1f6e04d3f0df457e

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Workflow/PostAction/CIBuild/Transition_PostAction_CIBuild.class.php +5 −5 Go to diff View file
M plugins/tracker/include/Workflow/Transition.class.php +10 −26 Go to diff View file
M plugins/tracker/include/Workflow/TransitionFactory.class.php +11 −11 Go to diff View file
M plugins/tracker/include/Workflow/Workflow.class.php +1 −1 Go to diff View file
M plugins/tracker/tests/unit/Workflow/PostAction/CIBuild/Transition_PostAction_CIBuildTest.php +6 −5 Go to diff View file