Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #13127 User can update an artifact keeping the same permission on artifact value

Download Browse

Given a tracker with only a permission on artifact field and given an artifact with a value for this field. A user can open the artifact for edition, open the field and then submit the artifact without changing the value. A new changeset is created with the same value, instead of having a message saying that there are no changes. This check must work for both Web UI and REST API. Additional note: the object artifact was modified without any good reasons in UpdateArtifact. This update (which is broken because the searched key in the request never exists) has been removed. Change-Id: I4a2dd812a4f8a4e05ee4e37229013f1301bc0423

+126 −4
Yannis ROSSETTO (rossettoy) 2019-03-20 11:09
Yannis ROSSETTO (rossettoy) 2019-03-20 11:09
f2ebea28ad86edc1dc0bf505351a197f7a78b3e3
9703ecd34c7f0df759fc88364e46cc991af60e86
git #tuleap/stable/f2ebea28ad86edc1dc0bf505351a197f7a78b3e3

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Action/UpdateArtifact.class.php +1 −2 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/PermissionsOnArtifact/ChangesChecker.php +38 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_PermissionsOnArtifact.class.php +2 −2 Go to diff View file
A plugins/tracker/phpunit/Tracker/FormElement/Field/PermissionsOnArtifact/ChangesCheckerTest.php +85 −0 Go to diff View file