Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: build Artifact link value outside of Field

Download Browse

part of story #24969 [modal] add and remove links without types No functional change expected. Conversion from REST value representation is done outside of Tracker_FormElement_Field_ArtifactLink. This will allow us to also recognize reverse links and handle them separately of $fields_data. Only forward links should end up in $fields_data eventually. Change-Id: I7e0f023ea07178a096beec87e793a6dde553e820

+412 −33
Joris MASSON (jmasson) 2022-03-22 12:21
Joris MASSON (jmasson) 2022-03-22 17:26
f5570e852d9c676e56b11ae2f395c5fb8cb91cee
e2af7e63e4b99d1822a9f8c180250e62dc16e1da
git #tuleap/stable/f5570e852d9c676e56b11ae2f395c5fb8cb91cee

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/REST/v1/Kanban/KanbanItemsResource.php +20 −1 Go to diff View file
M plugins/taskboard/include/REST/v1/Card/CardPatcher.php +20 −1 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +20 −1 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +20 −1 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/ExecutionsResource.class.php +33 −2 Go to diff View file
M plugins/tracker/include/REST/Artifact/ArtifactUpdater.php +2 −2 Go to diff View file
M plugins/tracker/include/REST/Artifact/Changeset/Value/FieldsDataBuilder.php +25 −6 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +33 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValue.php +8 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilder.php +2 −1 Go to diff View file
A plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ChangesetValuesContainer.php +52 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php +1 −3 Go to diff View file
M plugins/tracker/tests/unit/REST/Artifact/ArtifactUpdaterTest.php +15 −1 Go to diff View file
A plugins/tracker/tests/unit/REST/Artifact/Changeset/Value/ChangesetValuesContainerTest.php +79 −0 Go to diff View file
M plugins/tracker/tests/unit/REST/Artifact/Changeset/Value/FieldsDataBuilderTest.php +72 −10 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueBuilderTest.php +5 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueFormatterTest.php +2 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/UpdateValue/ArtifactLinksFieldUpdateValueTest.php +3 −1 Go to diff View file