Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Restler error response

Download Browse

Part of story #31173 register a new passkey This commit introduce class ErrorResponseBuilder which help to build error response in Restler format. If you create a API route but out of common API format (ie DispatchablePSR15Compatible), you cannot throw RestException in goal to send an error response. *Testing:* Fetch POST /webauthn/registration with error case (can be found in PostRegistrationControllerTest), it will return an error response in this format : { "error": { "code": int, "message": string } } Change-Id: If089822d94741e7dfb5ccb370432886e0eee848b

+157 −33
Kevin Traini (ktraini) 2023-04-20 09:04
Kevin Traini (ktraini) 2023-04-20 13:49
f7380d62a7bcad3df299740082ead70e0718a30f
b864fabcda91008f497c46cde0da33fbb8e7ce78
git #tuleap/stable/f7380d62a7bcad3df299740082ead70e0718a30f

Modified Files

Side by side diff
Inline diff
Name
A src/common/Http/Response/RestlerErrorResponseBuilder.php +51 −0 Go to diff View file
M src/common/Request/RouteCollector.php +10 −4 Go to diff View file
M src/common/WebAuthn/Controllers/PostRegistrationChallengeController.php +3 −3 Go to diff View file
M src/common/WebAuthn/Controllers/PostRegistrationController.php +12 −10 Go to diff View file
A tests/unit/common/Http/Response/RestlerErrorResponseBuilderTest.php +70 −0 Go to diff View file
M tests/unit/common/WebAuthn/Controllers/PostRegistrationChallengeControllerTest.php +5 −2 Go to diff View file
M tests/unit/common/WebAuthn/Controllers/PostRegistrationControllerTest.php +6 −14 Go to diff View file