Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Split checking of new Program Increment tracker

Download Browse

part of request #24994 : Javascript error in Iterations planning No functional change expected. Notes: The goal is to remove TrackerIsValidChecker static method and to split checking the validity of Program Increment, Iteration and Plannable Trackers. Program Management domain is not supposed to know what a Tracker is. Therefore, we must split the code that checks trackers are valid. This way, the underlying implementation could change independently. It is in fact still checked the same way as all three interfaces will be implemented by a single adapter that runs the same code. Renamed objects with "New" prefix and added comments to underline the fact that those objects exist to be saved in storage. Added a "SavePlan" interface to remove a mock. Change-Id: Ib2a3cda58111ea6d76bf47139976cb6c504cf5df

+540 −127
Joris MASSON (jmasson) 2022-01-13 15:03
Joris MASSON (jmasson) 2022-01-13 16:11
f7f6ce3ac2ec7e2e2fa3cb8806a30a9de4996ce2
4e270df72d0b285f191d8bd9afbbcd2e3560b0d3
git #tuleap/stable/f7f6ce3ac2ec7e2e2fa3cb8806a30a9de4996ce2

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Plan/PlanDao.php +2 −2 Go to diff View file
A plugins/program_management/include/Adapter/Program/Plan/TrackerConfigurationChecker.php +59 −0 Go to diff View file
A plugins/program_management/include/Adapter/Workspace/Tracker/RetrieveFullTrackerFromId.php +28 −0 Go to diff View file
M plugins/program_management/include/Adapter/Workspace/Tracker/TrackerFactoryAdapter.php +7 −5 Go to diff View file
A plugins/program_management/include/Domain/Program/Plan/CheckNewProgramIncrementTracker.php +39 −0 Go to diff View file
R plugins/program_management/include/Domain/Program/Plan/ProgramIncrementTracker.php Go to diff View file
M plugins/program_management/include/Domain/Program/Plan/Plan.php +8 −13 Go to diff View file
M plugins/program_management/include/Domain/Program/Plan/PlanCreator.php +4 −3 Go to diff View file
R plugins/program_management/include/Domain/Program/Plan/PlanStore.php Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +3 −0 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +19 −12 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Plan/TrackerConfigurationCheckerTest.php +84 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Workspace/Tracker/TrackerFactoryAdapterTest.php +19 −1 Go to diff View file
A plugins/program_management/tests/unit/Domain/Program/Plan/NewProgramIncrementTrackerTest.php +71 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Plan/PlanCreatorTest.php +38 −36 Go to diff View file
D plugins/program_management/tests/unit/Domain/Program/Plan/ProgramIncrementTrackerTest.php +0 −55 Go to diff View file
A plugins/program_management/tests/unit/Stub/CheckNewProgramIncrementTrackerStub.php +64 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/RetrieveFullTrackerFromIdStub.php +47 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/SavePlanStub.php +48 −0 Go to diff View file