Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring rules validator part date validation

Download Browse

part of request #13691 This patch only brings better and modern code to tracker rules validation. No fonctional changes are expected. The goal of the entire refactoring is to have a better, more maintainable and more testable code for futures changes in tracker rule validation. Change-Id: I57e396b24e060b4395da79565af916c6ef31c325

+311 −146
Lorentz Romain (lorentzr) 2019-08-09 14:59
Lorentz Romain (lorentzr) 2019-08-12 15:54
f83d032db0fa8185a72d7c7d1b33dac8cac1436e
f20fdee4caea39dca94572e56fc5a277e6d98188
git #tuleap/stable/f83d032db0fa8185a72d7c7d1b33dac8cac1436e

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.class.php +2 −0 Go to diff View file
A plugins/tracker/include/Tracker/Rule/TrackerRulesDateValidator.php +109 −0 Go to diff View file
M plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php +12 −77 Go to diff View file
M plugins/tracker/include/Workflow/WorkflowFactory.class.php +2 −0 Go to diff View file
A plugins/tracker/phpunit/Tracker/Rules/TrackerRulesDateValidatorTest.php +159 −0 Go to diff View file
M plugins/tracker/phpunit/Tracker/Rules/TrackerRulesManager/TrackerRulesManagerForbiddenTest.php +7 −2 Go to diff View file
M plugins/tracker/phpunit/Tracker/Rules/TrackerRulesManager/TrackerRulesManagerImportXMLTest.php +2 −1 Go to diff View file
M plugins/tracker/phpunit/Tracker/Rules/TrackerRulesManager/TrackerRulesManagerIsUsedInFieldDependencyTest.php +7 −0 Go to diff View file
M plugins/tracker/phpunit/Tracker/Rules/TrackerRulesManager/TrackerRulesManagerValidationTest.php +11 −66 Go to diff View file