Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: use LicenseAgreementControllersHelper evenly

Download Browse

Add tests on it and use it in all controllers. Closes story #14008 customize FRS Download Agreement in my project. Change-Id: I44c37e9abf201de65074cc10c805396b5071c4b5

+174 −123
Manuel Vacelet (vaceletm) 2019-11-08 17:54
Yannis ROSSETTO (rossettoy) 2019-11-12 15:14
f88e0ec2d898f4839d0eeffa62103d3c93d66682
8493a5ee5e1f894a02a8146c822e8e06d69d14a6
git #tuleap/stable/f88e0ec2d898f4839d0eeffa62103d3c93d66682

Modified Files

Side by side diff
Inline diff
Name
M src/common/FRS/LicenseAgreement/Admin/AddLicenseAgreementController.php +12 −14 Go to diff View file
M src/common/FRS/LicenseAgreement/Admin/EditLicenseAgreementController.php +13 −17 Go to diff View file
M src/common/FRS/LicenseAgreement/Admin/ListLicenseAgreementsController.php +14 −15 Go to diff View file
M src/common/Request/RouteCollector.php +12 −3 Go to diff View file
M tests/phpunit/common/FRS/LicenseAgreement/Admin/EditLicenseAgreementControllerTest.php +8 −38 Go to diff View file
A tests/phpunit/common/FRS/LicenseAgreement/Admin/LicenseAgreementControllersHelperTest.php +107 −0 Go to diff View file
M tests/phpunit/common/FRS/LicenseAgreement/Admin/ListLicenseAgreementsControllerTest.php +8 −36 Go to diff View file