part of request #27896 Smart commit is not smart enough How to test: When you push two commits with closing references for the same artifact, only the first one will try to close it. There will be only one follow-up comment by Tracker workflow manager. Notes: A new cache is added to work around two other inline caches. There is an inline cache in \Tracker_ArtifactFactory::getArtifactById(), so we always get the same Artifact object for a given ID. There is another one for the artifact's status in Artifact::getStatus(). When combined, it means we get twice the same Artifact object and it always answers "true" for Artifact::isOpen(). This means that if we handle two commits with closing references to the same artifact in the same process, the code will try to close the artifact twice because it always thinks the artifact is open, because the status is cached. The new cache works around that by skipping artifacts that we know we have already closed. Change-Id: I00678d7136c05e3581fc78d380a3c9841e15b0e5

+125 −1

Author

Joris MASSON (jmasson) 2022-08-12 15:56

Committer

Joris MASSON (jmasson) 2022-08-17 16:04

Hash f89741d892eaf9848feb21d2c640d6209f5009bc

Parent 753f664b9a8ba3b6c5b5f10b46aad585e1ca6899

Reference git #tuleap/stable/f89741d892eaf9848feb21d2c640d6209f5009bc