Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract update-specific request validator for planning admin

Download Browse

Part of story #15122 [release management] management of Aggregator projects This is a refactoring to make it easier to change the request validation rules for root plannings. The existing RequestValidator is used for planning creation from a form and XML and for planning update. Changing it would bring unintended side-effects. Also, planning updates have different validation constraints than planning creations. How to test: - No functional change expected. - Name, "planning tracker" and backlog trackers are mandatory and cannot be empty. Change-Id: I20d5678e7e57362347891847bf95a7388bccf691

+342 −42
Joris MASSON (jmasson) 2020-08-05 14:00
Joris MASSON (jmasson) 2020-08-05 16:26
fc1f0a39f8236dfa76846d935101cb38f7f6c035
a0ae208040c53ab9e8a95e0ad3076ab562c5f325
git #tuleap/stable/fc1f0a39f8236dfa76846d935101cb38f7f6c035

Modified Files

Side by side diff
Inline diff
Name
A plugins/agiledashboard/include/AgileDashboard/Planning/Admin/UpdateRequestValidator.php +119 −0 Go to diff View file
M plugins/agiledashboard/include/AgileDashboardRouter.class.php +10 −2 Go to diff View file
M plugins/agiledashboard/include/AgileDashboardRouterBuilder.php +2 −1 Go to diff View file
M plugins/agiledashboard/include/Planning/PlanningController.class.php +39 −31 Go to diff View file
A plugins/agiledashboard/tests/unit/AgileDashboard/Planning/Admin/UpdateRequestValidatorTest.php +146 −0 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Planning/PlanningControllerTest.php +24 −7 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboardRouterTest.php +2 −1 Go to diff View file