Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract part of updateFromRow in dedicated objects

Download Browse

part of story #12634 Add custom metadata in modal The aim of this patch is to ease the introduction of PUT/id/metadata routes In createFromRow we split logic of metadata value creation into a dedicated object we do the smae thing for metadata value update this patch only deals with docman core behaviour, it should not introduce functional changes Change-Id: Ibcbaa66b8e3c57f5e1c43940ce7e90d14cc2dd4e

+589 −198
Marie Ange Garnier (marieange) 2019-08-09 16:16
Marie Ange Garnier (marieange) 2019-08-09 16:23
fe2d333d01a20de9a7d167d6e55965e84e5c3540
6a2eec8a1a518804b127e97a1da8c28ba5cfc915
git #tuleap/stable/fe2d333d01a20de9a7d167d6e55965e84e5c3540

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/Docman_MetadataValueFactory.class.php +64 −79 Go to diff View file
M plugins/docman/include/Metadata/MetadataValueCreator.php +5 −50 Go to diff View file
A plugins/docman/include/Metadata/MetadataValueStore.php +126 −0 Go to diff View file
A plugins/docman/include/Metadata/MetadataValueUpdator.php +88 −0 Go to diff View file
M plugins/docman/include/REST/v1/Folders/DocmanItemCreatorBuilder.php +5 −2 Go to diff View file
M plugins/docman/phpunit/Metadata/MetadataValueCreatorTest.php +9 −67 Go to diff View file
A plugins/docman/phpunit/Metadata/MetadataValueStoreTest.php +160 −0 Go to diff View file
A plugins/docman/phpunit/Metadata/MetadataValueUpdatorTest.php +132 −0 Go to diff View file