stable

Clone or download

Read-only

chore(svn): 🔥 double REST SVN Settings verification

This closes request #35495 Do not allow suspended or deleted user in REST SVN notifications All the verifications done to build and validate REST SVN Settings is now done in a same object: SettingsBuilder. SettingsRepresentationValidator is completly removed. Change-Id: I6ba611501df7a0dee3d14707714a60eff1da9ff8

Modified Files

Name
M plugins/svn/include/REST/v1/RepositoryResource.php +0 −18 Go to diff View file
D plugins/svn/include/REST/v1/SettingsRepresentationValidator.php +0 −163 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/EmptyNotificationsFault.php +42 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/MissingAccessFileFault.php +36 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/NonAuthorizedDynamicUgroupFault.php +36 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/NonUniqueMailsFault.php +44 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/NonUniqueNotificationPathFault.php +39 −0 Go to diff View file
M plugins/svn/include/SVN/Repository/Settings/SettingsBuilder.php +80 −7 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/UgroupNotInProjectFault.php +36 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/UserInNotificationNotFoundFault.php +36 −0 Go to diff View file
A plugins/svn/include/SVN/Repository/Settings/UserNotAliveFault.php +36 −0 Go to diff View file
D plugins/svn/tests/unit/REST_Backend/SettingsRepresentationValidatorTest.php +0 −373 Go to diff View file
M plugins/svn/tests/unit/SVN/Repository/Settings/SettingsBuilderTest.php +216 −86 Go to diff View file