Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Backed enum for direction

Download Browse

part of request #40099 Cross-Tracker search finishing touches 16.1 No functional change expected in Cross-tracker search expert mode TQL. Why? Instead of repeating the same match expression, we use a string-backed enum for the sort direction. It also makes the parameters stricter (enum instead of any string). Change-Id: I91458108b1ebd027f8cb40797efc1f0ee0e8501f

+59 −52
Joris MASSON (jmasson) 2024-10-23 17:57
Joris MASSON (jmasson) 2024-10-24 12:10
feab2d029399ba9c392e0b2d53d3d0aba812bcc8
a82bf75223041126c3f652359cc1700bafd7e24f
git #tuleap/stable/feab2d029399ba9c392e0b2d53d3d0aba812bcc8

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/Date/DateFromOrderBuilder.php +3 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/FieldFromOrderBuilder.php +6 −11 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/Numeric/NumericFromOrderBuilder.php +3 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/StaticList/StaticListFromOrderBuilder.php +8 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/Text/TextFromOrderBuilder.php +8 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/UGroupList/UGroupListFromOrderBuilder.php +4 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/UserList/UserListFromOrderBuilder.php +4 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/UserList/UserOrderByBuilder.php +3 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Metadata/MetadataFromOrderBuilder.php +10 −14 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/UserList/UserOrderByBuilderTest.php +6 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/OrderByDirection.php +3 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidOrderByBuilderTest.php +1 −1 Go to diff View file