Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Edit service in a modal

Download Browse

Part of story #10913: Services management Go to project » admin » services. Edition of a service is now done in a modal. Please note that some simplifications have been made in conditions. For example, legacy docman does not exist anymore, and some check were done against a variable always true (bad naming => bad code): if (((!$ro)||($hp)) && (!$is_legacy_docman || $su)) with $hp = true, and $is_legacy_docman = false if (((!$ro)||(true)) && (!false || $su)) => if ((!$ro || true) && (true || $su)) => if (true && true) => if (true) Change-Id: I9d134ef9b2a996a482dc0d3de5c052cf399ef846

+246 −318
Nicolas Terray (nterray) 2018-02-02 17:59
Nicolas Terray (nterray) 2018-02-05 09:29
fee92c516f6f43b5b11f2d434ff2a246925bf7a3
2e575596bbd287acffc7bba9052de915cfc5e009
git #tuleap/stable/fee92c516f6f43b5b11f2d434ff2a246925bf7a3

Modified Files

Side by side diff
Inline diff
Name
M site-content/en_US/project/project.tab +1 −35 Go to diff View file
M site-content/fr_FR/project/project.tab +1 −35 Go to diff View file
M src/common/project/Service/ServicePresenter.php +31 −13 Go to diff View file
M src/common/project/Service/ServicesPresenter.php +1 −1 Go to diff View file
M src/common/project/Service/ServicesPresenterBuilder.php +27 −2 Go to diff View file
A src/templates/project/admin/services-edit-modal.mustache +175 −0 Go to diff View file
M src/templates/project/admin/services.mustache +10 −9 Go to diff View file
D src/www/project/admin/editservice.php +0 −223 Go to diff View file